Hi,
Ticket #686 registered.

I tried to reproduce on Demo (Ticket #8 = Test for Ticket #686) :
- uploaded a doc file (including images)
- I could download the file and open it

Could you try and reproduce on Demo :
- download doc attacked to ticket #8 and open it
- upload a doc file from yours, download it and open it.

Other questions :
- did the issue occur on previous version, or did it appear with V2.2 ?
- did you have any change on your server ?

Thanks.

Hi,

Sample file uploaded on document #9 :
- can be downloaded and opened without any issue

Your own file at the same place :
- can be downloaded, but cannot be opened
=> I check directly getting it from server : cannot be opened neither.
=> I'm afraid your file is corrupted at source.

No, it is not corrupted. I can open it from the source and from our server...

Could you please try, on the Demo :
- upload simple text file as document version
- upload same simple text file as attachment
- upload pdf file as document version
- upload same pdf text file as attachment
- upload doc file as document version (already done)
- upload same doc text file as attachment
Thanks.

You also tell me that uploaded file, fetched from server : how did you fetch it from server : SFTP ? in Binary or text mode ?

Very Strange.
It seems some UTF8 conversion has been applied.

What I did :
- download your file on Document #9 version 1.0
- open this doc with word : issue (request for conversion) :sick:
- open your doc with notepad, check encoding (= UTF8), change encoding to ANSI, save
- open this doc with word : OK :woohoo:
- upload this new doc as V3
- download the V3 doc, open it with word : OK :woohoo:

It seems that it is your upload that got wrong.
What browser are you using ? What version ?

I have tried with Firefox and IE - result id the same...
So somehow upload changing encoding to UTF-8

Hi,

I worked on this issue and could not reproduce your upload issue.
I'm afraid I must be able to reproduce to find a workaround.

I also tried to change default encoding, but with no success.
Can you tell me what your encoding charset is ?
(on Firefox : Tools / Options / Content / Advanced button (on fonts) / encoding charset)
Thanks.

Hi Evgueni,

I still try to fix this issue but whatever I try, I cannot reproduce.
- are you still facing the issue ?
- Can you tell me what your encoding charset is (on your browser configuration) ?
- on your first posts, you said the file was OK on server, but KO when downloading, but when you tried it on Demo, I got a wrong format on the server (with some UTF-8 translation), and after fixing on server, I could download OK. Could you confirm the diagnostic : file OK on server (error on download) of file KO on server (error on upload).

Thanks.

Default is Western (ISO-8859-1)

Ok, we have found and fixed the problem:
Added the ob_clean() and flush() command before the readfile in download.php
e.g., in tool/download.php
ob_clean();
flush();
readfile($file);
Now everything is OK - please implement into main stream
Regards,
Evgueni

Hi,

Great you found a fixing !

I'll try it to include it in next version.
I want to investigate about the flush() method : not sure the result will be the same on Windows (flush does not immediatly sends result to browser) and Linux (flush immediatly sends result to browser). I'll test it before including it.

Many thanks.

Hi,

You solution works fine on my windows environment, but fails on my Linux environment :

ERROR : ob_clean()
failed to delete buffer. No buffer to delete
in download.php
at line 51

It seems that ob_clean() fails on Linux if buffer is empty.
In your case, your server should add some extra characters that fills the buffer (leading to original download issue).
I fixed this way :

  if (ob_get_length()){   
    ob_clean();
  }
  flush();

This solution brings no regression for me. Tested :
- with Windows XP and Linux servers
- using browser : Chrome 19, Firefox 12 and IE 8
- downloading : ticket attachment file, document version file

Could you please test this solution and confirm that it still fixes the issue in your case ?
Thanks.

Used your code and still seems to work.
(Oddly enough we're running a linux server....)
Regards,
Evgueni

Great !
So this fix will be included in V2.3