Forum

Notifications
Retirer tout

todo list

4 Posts
2 Utilisateurs
0 Reactions
1,286 Vu
 M
(@mkavurcic)
Posts: 43
Trusted Member
Début du sujet
 
[#8739]

Please review the following:

  • todo list items (status - "in progress") on activity (status all but "done") display on today screen as well as on todo list screen - that's ok
  • todo list items (status - "done") on activity (status all but "done") don't display on today screen but display on todo list screen when "done" field checked - that's ok
  • todo list items (status - "in progress") on activity (status "done") display on today screen but don't display on todo list screen - that's odd
  • todo list items (status - "done") on activity (status "done") don't display on today screen - that's ok, and can't be displayed on todo list screen even when "done" field checked - this may be ok - if only todo items of not done activities were supposed to be shown, and may not be ok - if you want to review all todo list items in your project

thanks


 
Posté : 13/02/2023 3:40 pm
(@babynus)
Posts: 14952
Membre Admin
 

Todo in Today screen shows the Todo depending on Todo Status only.
Only Todo for Closed activities are hidden.
Todo "in progress" for activities "done" are displayed : it may be a delivery task, bug fixing, closure request, ...

Hiding all Todo for done activities on Todo screen is weird. 
We'll have a look and possibly fix this.
 


 
Posté : 18/02/2023 7:10 pm
 M
(@mkavurcic)
Posts: 43
Trusted Member
Début du sujet
 

in SubTask.php line 580 I adapted few lines of code and now it works (for me); please try and check if all privs. and sec.features are preserved

if (
#mk($element->idle==1) or ($element->done==1) or
($rightUpdate=='NO' and $rightRead=='NO') or (!$rightUpdate and !$rightRead))continue;

$where="refType= '".$obj['reftype']."' and refId = ".$element->id;
$crit=array();
if(!$showClosedSubTask and !$showDoneSubTask ){
$crit=array("done"=>'0',"idle"=>'0');
}else if($showDoneSubTask and !$showClosedSubTask){
$crit=array("done"=>'1',"idle"=>'0');
//mk add
}else if($showDoneSubTask and $showClosedSubTask){
$crit=array("done"=>'0',"idle"=>'1');
}

-----------------------------------

further, I suggest to supply ResponsibleTodoList parameter in Today.php, line 43
 public static $staticList=array('Projects','AssignedTasks','ResponsibleTasks', 'AccountableTasks', 'IssuerRequestorTasks','ProjectsTasks','ResponsibleTodoList','Documents');


 
Posté : 21/02/2023 2:41 pm
(@babynus)
Posts: 14952
Membre Admin
 

Hi,

Thanks for you fix.
We already fixed this issue, not the way you propose, but I think it will give same result.


 
Posté : 24/02/2023 1:25 pm
Share:
Retour en haut