Forum

Job check time
 
Notifications
Retirer tout

Job check time

4 Posts
2 Utilisateurs
0 Reactions
2,269 Vu
(@papjul)
Posts: 143
Active Member
Début du sujet
 
[#4249]

Hi,

Could you explain what was the issue with job check time that you removed in this commit?
https://sourceforge.net/p/projectorria/code/3926/#diff-2

Thanks,


 
Posté : 3 Avr PM 12:044
(@babynus)
Posts: 14952
Membre Admin
 

The error was that jobCheckTime was changed everytime, even if job was not changed at all.
This lead to message "job saved" each time you saved an item with jobs, even with no change. So you never had "no change" message.


 
Posté : 4 Avr AM 10:044
(@papjul)
Posts: 143
Active Member
Début du sujet
 

I see, indeed, then we should update checkTime if $old->value != $new->value, right?


 
Posté : 4 Avr AM 11:044
(@babynus)
Posts: 14952
Membre Admin
 

No need.
It is already done in saveJioblist.php

    if (isset($_REQUEST[$checkName])) {
        $checkedCpt++;
        if (!$valLine->value) {
            $checkedCptChanged++;
            $valLine->checkTime = date('Y-m-d H:i:s');
        }
        $valLine->value = 1;

 
Posté : 5 Avr AM 00:044
Share:
Retour en haut