Forum

Job check time
 
Notifications
Retirer tout

Job check time

4 Posts
2 Utilisateurs
0 Reactions
2,268 Vu
(@papjul)
Posts: 143
Reputable Member
Début du sujet
 
[#4249]

Hi,

Could you explain what was the issue with job check time that you removed in this commit?
https://sourceforge.net/p/projectorria/code/3926/#diff-2

Thanks,


 
Posté : 03/04/2017 12:59 pm
(@babynus)
Posts: 14952
Membre Admin
 

The error was that jobCheckTime was changed everytime, even if job was not changed at all.
This lead to message "job saved" each time you saved an item with jobs, even with no change. So you never had "no change" message.


 
Posté : 04/04/2017 10:30 am
(@papjul)
Posts: 143
Reputable Member
Début du sujet
 

I see, indeed, then we should update checkTime if $old->value != $new->value, right?


 
Posté : 04/04/2017 11:08 am
(@babynus)
Posts: 14952
Membre Admin
 

No need.
It is already done in saveJioblist.php

    if (isset($_REQUEST[$checkName])) {
        $checkedCpt++;
        if (!$valLine->value) {
            $checkedCptChanged++;
            $valLine->checkTime = date('Y-m-d H:i:s');
        }
        $valLine->value = 1;

 
Posté : 05/04/2017 12:12 am
Share:
Retour en haut