Forum

Welcome to ProjeQtOr new Forum. We migrated old forum to the new website.
You will find all your posts here, with your usual account.
Just one point : you’ll have to reinitialize your password. Use “Lost password” feature.

Job check time
 
Notifications
Clear all

Job check time

4 Posts
2 Users
0 Reactions
2,298 Views
(@papjul)
Posts: 143
Active Member
Topic starter
 
[#4249]

Hi,

Could you explain what was the issue with job check time that you removed in this commit?
https://sourceforge.net/p/projectorria/code/3926/#diff-2

Thanks,


 
Posted : 03 Apr 2017 12H59
babynus
(@babynus)
Posts: 14966
Main Contributor Admin
 

The error was that jobCheckTime was changed everytime, even if job was not changed at all.
This lead to message "job saved" each time you saved an item with jobs, even with no change. So you never had "no change" message.


 
Posted : 04 Apr 2017 10H30
(@papjul)
Posts: 143
Active Member
Topic starter
 

I see, indeed, then we should update checkTime if $old->value != $new->value, right?


 
Posted : 04 Apr 2017 11H08
babynus
(@babynus)
Posts: 14966
Main Contributor Admin
 

No need.
It is already done in saveJioblist.php

    if (isset($_REQUEST[$checkName])) {
        $checkedCpt++;
        if (!$valLine->value) {
            $checkedCptChanged++;
            $valLine->checkTime = date('Y-m-d H:i:s');
        }
        $valLine->value = 1;

 
Posted : 05 Apr 2017 0H12
Share:

Scroll to Top